calibrate and addition of t0
Summary
If I understand the code correctly, and excuse me if I don't, using utils.calibrate.py (or via the entry point by typing 'calibrate') should add t0 to the times of hits in the calibrated file. However, this seems to sometimes silently not work, i.e. w/o producing an error message. E.g., t0 is added for mupage files, but not for real data. From what I have seen so far, it seems that using calib.Calibration as part of a pipeline does not have this issue.
Environment
- KM3Pipe version (
km3pipe --version
): 8.16.2 - Python version (
python --version
): 2.7.16 - OS: (
uname -a
): Linux cca009 3.10.0-957.12.2.el7.x86_64 #1 (closed) SMP Tue May 14 21:24:32 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Additional information
(The following are optional but may be relevant.)
- HDF5 metadata (
h5info /path/to/relevant/file.h5
) - ROOT file metadata (
JPrintMeta -f /path/to/relevant/file.root
): - Jpp version (only if relevant,
JPrint -v
)
Describe the current bug behavior
hits/time/ in the calibrated file is sometimes identical to hits/time/ before calibration.
Describe the expected correct behavior
calibrated time = not calibrated time + t0, always.
Steps to reproduce
- Download a real data file, e.g. iget /in2p3/km3net/data/trigger/JTR/KM3NeT_00000029/v0.3/2/KM3NeT_00000029_00002980.jtr.root
- tohdf5
- copy the h5 file
- calibrate the copied file via 'calibrate' and the corresponding detx file (/sps/km3net/repo/data/calibration/KM3NeT_00000029/v1.0/T0Corr/KM3NeT_00000029_00002980_DB_PMT_noref.detx)
- compare hits/time/ in the calibrated file to that which is not calibrated. The times are identical.
Repeat the above steps for a mupage file, e.g. iget /in2p3/km3net/mc/atm_muon/KM3NeT_00000029/v5.1_r3/trigger/mcv5.1_r3.mupage_10G.km3_AAv1.jterbr00002980.713.root The times are not identical, as t0 was added as expected.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (put the code between ```) to format console output, logs, and code as it's very hard to read otherwise.)