Best reco hits events (!15) · Merge requests · km3py / km3io · GitLab

Snippets Groups Projects

Merged Zineb Aly requested to merge best-reco-hits-events into master 5 years ago

1 unresolved thread

This addresses issues #22 (closed) and #24 (closed)

This is ready for merge into master. Although I am not sure I understand why the code style fails here on git (I updated yapf on my computer and used it to correct the code style but maybe I am missing a detail here?).

Edited 5 years ago by Zineb Aly

Activity

Zineb Aly added 1 commit 5 years ago
added 1 commit

d29dfe5e - add docs in README

Compare with previous version
Zineb Aly added 1 commit 5 years ago
added 1 commit

593ba77f - correct code style

Compare with previous version
Tamas Gal added 1 commit 5 years ago
added 1 commit

5eed17e9 - Make yapf

Compare with previous version
Tamas Gal @tgal · 5 years ago

Owner

I just did a make yapf locally and it indeed corrected offline.py. Not sure why it didn't on yours?

Anyways, thanks for the upgrade!
Zineb Aly @zaly · 5 years ago

Author Maintainer

interesting .... I did the exact same procedure as you. Not sure what's happening on my computer, I will investigate it further... Thanks!
Tamas Gal @tgal started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Tamas Gal
Last reply by Zineb Aly 5 years ago

Tamas Gal @tgal started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Tamas Gal

Zineb Aly added 1 commit 5 years ago

added 1 commit

177d30c6 - remove sets

Compare with previous version

Zineb Aly changed the description 5 years ago

changed the description

Zineb Aly added 1 commit 5 years ago

added 1 commit

3ac93175 - fix code style

Compare with previous version

Tamas Gal @tgal · 5 years ago

Owner

Is this MR ready or should we add WIP?

Tamas Gal resolved all threads 5 years ago

resolved all threads

Zineb Aly @zaly · 5 years ago

Author Maintainer

This is ready ;)

Tamas Gal @tgal started a thread on an old version of the diff 5 years ago

km3io/offline.py

             do not contain data. Therefore, the keys corresponding to these
             fake branches are not read.
         """
         if key not in self.keys.valid_keys and not isinstance(key, int):
         keys = set(self.keys.valid_keys)

Tamas Gal @tgal started a thread on the diff 5 years ago

Resolved 5 years ago by Tamas Gal

Zineb Aly added 1 commit 5 years ago

added 1 commit

48ded485 - remove sets

Compare with previous version

Zineb Aly enabled an automatic merge when the pipeline for succeeds 5 years ago

enabled an automatic merge when the pipeline for 48ded485 succeeds

Zineb Aly merged 5 years ago

merged

Zineb Aly mentioned in commit 5 years ago

mentioned in commit a9a6416a

Please register or sign in to reply