Skip to content
Snippets Groups Projects

Refactor offline

Closed Refactor offline
refactor-offline into master
Closed Tamas Gal requested to merge refactor-offline into master

This refactoring includes some slicing and performance improvement attempts.

The slicing is still experimental and has some flaws:

  • fancy indexing over thousands of elements might be horrible slow, eg f.events.tracks[idx_list, 0] where idx_list is a huge list of indices
  • trivial problem of iterating: for track in f.evens.tracks does not stop after the last element
  • meaningless indexing: f.events[5][23][420] is simply f.events[420] since the index/slice is not chained but overwritten when propagated. We need custom checks whether it makes sense
    • events are flat lists, so [x][y] does not make sense, it should throw an error
    • f.events[5:23][4] should effectively be the same as f.events[9] due to chaining of slice/index
Edited by Tamas Gal

Merge request reports

Pipeline #10193 passed with warnings

Stage: test
Stage: coverage

Pipeline passed with warnings for 7d7e4842 on refactor-offline

Test coverage 97.23% (-1.39%) from 1 job
Approval is optional

Closed by Tamas GalTamas Gal 4 years ago (Apr 1, 2020 2:36pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply