Skip to content
Snippets Groups Projects

Add acoustics monitoring

Merged Carlo Guidi requested to merge cguidi/km3mon:undefined into master

I do not know if I'm doing the right thing. I tried to upload the script "acoustic.py" and I am asked to send a merge request. Is this the correct procedure? @tgal Thank you

Edited by Tamas Gal

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • Tamas Gal
  • @cguidi I started reviewing but there are many problems in the code. Can you please go through some of my comments and try to split up your code into smaller functions and better variable names?

    Also we use the PEP-8 coding style, could you please reformat your code according to that? https://www.python.org/dev/peps/pep-0008/

  • assigned to @cguidi

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading