Add acoustics monitoring

I do not know if I'm doing the right thing. I tried to upload the script "acoustic.py" and I am asked to send a merge request. Is this the correct procedure? @tgal Thank you

scripts/acoustics.py

@@ -37,8 +37,6 @@ def diff(first, second):
     second = set(second)
     return [item for item in first if item not in second]
 
-#print(time.time())
-
 db = kp.db.DBManager()
 sds = kp.db.StreamDS()
 table=db.run_table(detid)
@@ -51,10 +49,6 @@ DOMS = range(N_DOMS + 1)
 N_DUS = 5
 DUS = range(1, N_DUS + 1)
 
-#ACOUSTIC_BEACONS=[16] # Acoustic Beacons
-#DOMS=[7] # DOMs
-#DUS=[3] # DUs
-
 TIT=600 # Time Interval between Trains of acoustic pulses)
 SSW=160 # Signal Security Window (Window size with signal)
 
@@ -71,14 +65,14 @@ while check==True:
         minrun=table["RUN"][len(table["RUN"])-1]-1 
     print(now)
 
-    COL=[]
+    N_Pulses_Indicator=[] # Matrix indicating how many pulses each piezo reveals
     for du in DUS:
-        N_Pulses_Indicator=[] # Array indicating for each DU how many pulses each piezo reveals.
+        N_Pulses_Indicator_DU=[] # Array indicating for each DU how many pulses each piezo reveals.
         for ab in ACOUSTIC_BEACONS:
             for dom in DOMS:
                 try:
-                    macaddress = db.doms.via_omkey((du,dom), detid).dom_id
-                    toas_all = sds.toashort(detid=detid, minrun=minrun, maxrun=maxrun, domid=macaddress, emitterid=ab) # Prendere i dati basandosi sul tempo e non sul run????
+                    domID = db.doms.via_omkey((du,dom), detid).dom_id
+                    toas_all = sds.toashort(detid=detid, minrun=minrun, maxrun=maxrun, domid=domID, emitterid=ab) 
                 
                     QF_abdom=toas_all["QUALITYFACTOR"]
                     UTB_abdom=toas_all["UNIXTIMEBASE"]
@@ -112,11 +106,12 @@ while check==True:
                     noise_threshold=max(NOISE) 
                     
                     # First filter: 22 greatest
+                    Security_Number=22 # To be sure to take all the pulses
                         
                     SIGNAL=SIGNAL.tolist()
                     SIGNAL_OLD=np.array(SIGNAL)
                     SIGNAL.sort(reverse=True)
-                    QF_first=SIGNAL[0:22]
+                    QF_first=SIGNAL[0:Security_Number]
                     
                     # Second filter: delete duplicates
                     
@@ -138,13 +133,11 @@ while check==True:
                     
                     # Fifth filter: Check if the clicks are interspersed in the right way
                     
-    #                    QF_fifth=[k for k in QF_fourth if (abs(k-max(QF_fourth))<abs(k-noise_threshold))]
                     Q=[]
                     for q in np.arange(len(QF_fourth)):
                         Q.append(np.where(SIGNAL_OLD==QF_fourth[q])[0][0])
                     UTB_fourth=np.array(UTB_SIGNAL.tolist())[Q]
                     UTB_fourth_l=UTB_fourth.tolist()
-    #                    UTB_fourth_l.sort()
                     D=[]
                     for g in np.arange(len(UTB_fourth_l)):
                         if ((np.mod((UTB_fourth_l[g]-UTB_fourth_l[0]),5)>0.5 and np.mod((UTB_fourth_l[g]-UTB_fourth_l[0]),5)<4.5) or (np.mod((UTB_fourth_l[g]-UTB_fourth_l[0]),5)>5)):
@@ -154,24 +147,24 @@ while check==True:
                     QF_fifth=QF_fourth
                     QF_OK=QF_fifth
     #                print(QF_OK)
-                    NUM=len(QF_OK)
+                    NUM=len(QF_OK) # Number of pulses
                     print(NUM)
                     
                     if (NUM>7):
-                        N_Pulses_Indicator.append(1.5)
+                        N_Pulses_Indicator_DU.append(1.5)
                     elif (NUM<8 and NUM>3):
-                        N_Pulses_Indicator.append(0.5)
+                        N_Pulses_Indicator_DU.append(0.5)
                     elif (NUM<4 and NUM>0):
-                        N_Pulses_Indicator.append(-0.5)
+                        N_Pulses_Indicator_DU.append(-0.5)
                     elif (NUM==0):
-                        N_Pulses_Indicator.append(-1.5)
+                        N_Pulses_Indicator_DU.append(-1.5)
 
                         
                 except:
                     stop=[]
-                    N_Pulses_Indicator.append(-1.5)
+                    N_Pulses_Indicator_DU.append(-1.5)
                     
-        COL.append(N_Pulses_Indicator)
+        N_Pulses_Indicator.append(N_Pulses_Indicator_DU)
         
     
     
@@ -199,11 +192,11 @@ while check==True:
     
     
     
-    DU1=np.array(COL[0])
-    DU2=np.array(COL[1])
-    DU3=np.array(COL[2])
-    DU4=np.array(COL[3])
-    DU5=np.array(COL[4])
+    DU1=np.array(N_Pulses_Indicator[0])
+    DU2=np.array(N_Pulses_Indicator[1])
+    DU3=np.array(N_Pulses_Indicator[2])
+    DU4=np.array(N_Pulses_Indicator[3])
+    DU5=np.array(N_Pulses_Indicator[4])
     
     ind=np.where(DU2<1000)
     iAB1=np.where(ind[0]<l)
@@ -264,7 +257,7 @@ while check==True:
     print(check_time)
     
     
-    time.sleep(abs(600-check_time))
+    time.sleep(abs(TIT-check_time))
     check=True