cleaning and adding new features
Hi @tgal I've had a look at this project after our small chat. I use this issue to dump here some proposals for cleaning the project:
-
Remove anything detector specific. So
aeff.py
andweights.py
I would move them to a different package. -
Include the astrophysical neutrino flux parameterisation. In the file 'flux.py' there's a class called
PowerLawFlux
. I would replace it with aCosmicFlux
class, and implement it according to the parameterisation given by IceCube: See formula 2 here. To get the individual channel contribution to that flux, we'd need to divide by 6 (nu, anu times three flavors). -
For the dark matter fluxes, I'm not sure if the implemented ones are most standard one. I didn't see in the inline code documentation any reference to a specific paper where these fluxes are reported. On the other hand I see htat there's a reference for the atmospheric flux. If we don't know where these fluxes are coming from, I would remove them and perhaps ask the exotics group to provide the most popular references